First come first served: The impact of file position on code review

Fregnan, E., Braz, L., D’Ambros, M., Calikli, G. and Bacchelli, A. (2022) First come first served: The impact of file position on code review. In: ACM Joint European Software Engineering Conference and Symposium on the Foundations of Software Engineering (ESEC/FSE 2022), Singapore, 14-18 November 2022, pp. 483-494. ISBN 9781450394130 (doi: 10.1145/3540250.3549177)

Abstract

The most popular code review tools (e.g., Gerrit and GitHub) present the files to review sorted in alphabetical order. Could this choice or, more generally, the relative position in which a file is presented bias the outcome of code reviews? We investigate this hypothesis by triangulating complementary evidence in a two-step study. First, we observe developers’ code review activity. We analyze the review comments pertaining to 219,476 Pull Requests (PRs) from 138 popular Java projects on GitHub. We found files shown earlier in a PR to receive more comments than files shown later, also when controlling for possible confounding factors: e.g., the presence of discussion threads or the lines added in a file. Second, we measure the impact of file position on defect finding in code review. Recruit- ing 106 participants, we conduct an online controlled experiment in which we measure participants’ performance in detecting two unrelated defects seeded into two different files. Participants are assigned to one of two treatments in which the position of the defective files is switched. For one type of defect, participants are not affected by its file’s position; for the other, they have 64% lower odds to identify it when its file is last as opposed to first. Overall, our findings provide evidence that the relative position in which files are presented has an impact on code reviews’ outcome; we discuss these results and implications for tool design and code review.

• Item Type: Conference Proceedings
• Status: Published
• Refereed: Yes
• Glasgow Author(s) Enlighten ID: Calikli, Dr Handan Gul
• Authors: Fregnan, E., Braz, L., D’Ambros, M., Calikli, G., and Bacchelli, A.
• College/School: College of Science and Engineering > School of Computing Science
• ISBN: 9781450394130
• Copyright Holders: © 2022 Copyright held by the owner/author(s).
• First Published: First published in ESEC/FSE 2022: Proceedings of the 30th ACM Joint European Software Engineering Conference and Symposium on the Foundations of Software Engineering
• Publisher Policy: Reproduced in accordance with the publisher copyright policy

Related URLs

• Publisher
• Organisation

• Data DOI: 10.5281/zenodo.6901285